Snayff / nqp2

An exploration of a fantasy world, to autobattle your way to ruling the demesne.
https://snayff.github.io/nqp2/
Other
12 stars 5 forks source link

fix/failing_tests #307

Closed douglascdev closed 2 years ago

douglascdev commented 2 years ago

Fix failing tests. Changes so far:

I don't know if the changes I made make sense, so I commented on every change to the code with my reasoning for doing it, hoping I can get a review on whether they make sense or not. I'm skipping two more tests that I don't know how to fix, hoping to fix those after getting some feedback as well.

douglascdev commented 2 years ago

I'll be closing this one since bitcraft is a lot more acquainted with how the tests should behave and will do a much better job at fixing them.

@bitcraft thank you for taking the time to review it :blush: