Snayff / nqp3

1 stars 2 forks source link

refactor ref_data to use RefCounted #39

Closed eh-jogos closed 1 year ago

eh-jogos commented 1 year ago

This is a "proposal" for a way to use ref_data with RefCounted objects instead of Dictionaries.

I think it will be a little bit easier to create new ones when you don't want to override a lot of stats, adds type completion when using it in code, and automates passing the data from UnitData to ActorStats, so we don't have to give it maintenance, just add the same property on both and it works.

Snayff commented 1 year ago

I've looked at this twice now and it isnt clicking for me. I'll pull the branch and play around locally, see if that does the trick.

eh-jogos commented 1 year ago

Just updated this PR rebasing it to curent develop and fixing some mistakes