Basic Playable Commander

[eh-jogos]

Commander actions:

• Sony Square, Xbox X or keyboard J - smash
• Sony Triangle, Xbox Y or keyboard I - wand_blast
• Left Analogue Stick or dpad, or wasd - move

Limitations

• dpad is really bad for me on a playstation 4 controller, movement stops randomly even though I'm holding the dpad down. Do you have other controllers to test? Does it happen with them as well?
• "End Game" is just a print according to if you won or lost and the games gets paused, but can't be unpaused.
• All that's left from #8 is to make the Enemy commander run away when they're low on health. Everything else is working one way or another I think. Let me know if I missed something else.
• Current number of actions the player commander can do is limited to 4 attacks. one for each face button in the controller. The Unit can have more actions, they're just not currently accessible in any way for the player commander
• added an optional states_base_folder parameter to StateMachine's _init so we can override the base folder add_state uses, but I think this needs to be a "per state" path, because for example, player_actor/dead.gd and actor/dead.gd are essentially the same, but I have to duplicate them because add_state will only search in a single folder. If we could set the path for each state we could mix and match states from compatible units, or states that are the same regardless of unit.

Implementation

A lot of stuff happened on the commits bellow, but the overview is:

• PlayerActor has some custom functions for targetting, and it tries to find a target for each available attack.
• Once player presses a button, it will try to use the respective attack.
• Attacks are assigned in to the buttons according to the order they are added, so first attack will be square, second triangle, third circle, and fourth Cross.

Some other important changes among the commits below that I remember:

• refactored factory.gd a bit, so that it is a bit more DRY compared to how I had left it before when I added create_player_actor()
• added path_base_sprites to red_data so that we can easily change the path for sprites
• about changes to target logic:
  • Tried to make it more straightforward to read and error proof
  • Moved fallback target logic to AI script as it is something that we want to be executed every time a target is being searched
  • Added check for units being alive in fallback targeting logic, otherwise actors get stuck targeting dead enemies because the first entry in the groups array is a dead enemy
  • removed refresh timer from function because it was being discarded since _attempt_target_refresh would restart the timer right after

[Snayff]

Looks good. Want me to merge or want to wait until you've done the enemy Commander running away? In fact, happy to split that into another Issue, as it will likely require work related to #16 or #15 , so might be better to tackle the whole problem, rather than only a specific use case.

[eh-jogos]

Yeah, I think it's better to merge this one! Creating a separate Issue for commander running away seems better!