Snd-R / komf

Komga and Kavita metadata fetcher
MIT License
299 stars 17 forks source link

Komf not fetching "ja-ro" from Mangadex #142

Closed Xian-beep closed 1 month ago

Xian-beep commented 5 months ago

Since the last two updates it seems like "ja-ro" doesn't fetch anymore from Mangadex as a source. It should in this case display as "Sousou no Frieren" and not "Frieren at the Funeral". I have more examples in my library, some that just have the Japanese characters and not ja-ro or en.

Mangadex:

![image](https://github.com/Snd-R/komf/assets/83923843/d490e46c-50f0-4098-bd63-7ae59b288d4e)

Komga with komf configured to use "ja-ro" as main title:

![image](https://github.com/Snd-R/komf/assets/83923843/86ac6645-4b5e-4a43-a9d7-9d5a4f09c342)

Configuration snippet for the library in question:

0ER2MAAPBRZK6:
     updateModes: [ API ]
     aggregate: false
     bookCovers: true
     seriesCovers: true
     overrideExistingCovers: true
     postProcessing:
          seriesTitle: true
          seriesTitleLanguage: "ja-ro"
          alternativeSeriesTitles: true
          alternativeSeriesTitleLanguages:
             - "en"
             - "ja"
Snd-R commented 5 months ago

Komf maps language tags directly from mangadex response. In you case that manga technically didn't have a ja-ro title
1 Also Komf ignores main title completely and only takes altTitles since main title often tagged wrong. As is the case in your example where it's marked as en instead of ja-ro

Snd-R commented 5 months ago

Also a recent change was that Komf will now take the first matching alternative title and set it as a main #95 First matching alt title would be english "Frieren at the Funeral" was added in https://github.com/Snd-R/komf/releases/tag/0.32.0

I might reconsider it and instead make it an optional config flag. If you'd like to have old behavior back, please create a new issue

Sonny-Crockett commented 4 months ago

image

I don't know if this is related to that issue, but I am also using Mangadex and trying to source both EN and JA-RO titles?

Like afaik if I choose a default language and the file name is JA-RO, should Komf rename the entry in Kavita to EN and put the OG title under "Localized Name" or something? Example: change Uchuu Kyoudai(file name) to Space Brothers.

Snd-R commented 1 month ago

Closing it as it is an upstream issue