Inadequate URL encoding / illegal character escaping

Snd-R / komf

Komga and Kavita metadata fetcher

MIT License

323 stars 19 forks source link

Inadequate URL encoding / illegal character escaping #149

Closed blathers16 closed 5 months ago

blathers16 commented 5 months ago

Fetching metadata for series with via Manga Updates with alternate titles with illegal? characters in them fails. I have attached the log for this, as well as a plain text copy/paste of the title with the issue from manga updated. Let me know if you need any more info.

komf_komf-custom-app-69bd5db87c-z49nw_komf-custom-app.log worthless_blacksmith_manga_updates_jp_title.txt

Snd-R commented 5 months ago

Seems like Komga does not accept non url encoded query params in links. In this case MangaDex had this link that wasn't properly encoded. https://www.cdjapan.co.jp/searchuni?fq.category=UD:14&q=不遇職『鍛冶師』だけど最強です　～気づけば何でも作れるようになっていた男ののんびりスローライフ～&order=reldesc

blathers16 commented 4 months ago

@Snd-R, could you please cut a release for this? I have run into a few more errors that might be related to this or something else, and I would like to rule this out before filing another bug. Also, I still can't update this series.

Snd-R commented 4 months ago

released in https://github.com/Snd-R/komf/releases/tag/0.34.2