Snd-R / komf

Komga and Kavita metadata fetcher
MIT License
295 stars 17 forks source link

It adds completed manga as ongoing #37

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi I started using komf yesterday, everything was fine, but today for some reason it's adding completed manga as ongoing. OS: Arch Linux komf:0.18.2 komga: 0.160.0 Running komga with systemd for all users (system-wide) (java -jar komga) , Running komf systemd as well (java -jar komf.jar --config-dir=/home/user/komf) https://termbin.com/9fo36 application yml

applesoff commented 1 year ago

You can check the komf log to see where it's pulling metadata from based on your application.yml It seems like manga updates and any list are your top two. Check their sites to see if they have incorrect information about ongoing verse ended series. I've had this issue before. I try to use official sources to prevent this

ghost commented 1 year ago

@applesoff First of all, thank you for your quick reply, I didn't see such a problem when I checked, I guess the problem is that when more than one volume information is entered in mangaupdates, it seems to me that the komf is getting confused. Let me explain my theory with examples. Kokou no Hito 17 Volumes (Complete) komf added it as Completed Fullmetal Alchemist 27 Volumes (Complete) 14 Volumes (Keisouban, Complete) 18 Volumes (Kanzenban, Complete) komf added it as Ongoing Ping Pong 5 Volumes (Complete)3 Volumes (Shinsouban ABC, Complete) 1 Volume (Soushuuhen, Complete) 3 Volumes (Bunkoban, Complete)2 Volumes (Full Game ed., Complete) komf added it as Ongoing Soul Eater 25 Tankoubon Volumes (Complete) 17 Kanzenban Volumes (Complete) komf added it as Ongoing

Snd-R commented 1 year ago

Not sure what would be the right behavior for cases when mangaupdates contains both completed and ongoing volume information, to be safe I suppose it should just not return data about status But for cases when all volume types are completed it does makes sense to mark whole series as completed

ghost commented 1 year ago

@Snd-R i think as u said if all volume type is completed then let komf set as completed