github-actions[bot]
commented
5 months ago Coverage after merging service-injections-and-configuration into main will be
| 78.67% |
|---|
Coverage Report
| File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|---|
| src/Configurations | |||||
| MetricsPublisherActorConfiguration.cs | 100% | 100% | 100% | 100% | |
| MetricsReporterConfiguration.cs | 100% | 100% | 100% | 100% | |
| src/Extensions | |||||
| KubernetesObjectExtensions.cs | 100% | 100% | 100% | 100% | |
| StreamClassPhaseExtensions.cs | 100% | 100% | 100% | 100% | |
| V1JobExtensions.cs | 82.24% | 63.64% | 94.12% | 89.01% | 105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 53, 53, 58, 68, 68, 75, 83–84, 84, 84, 84, 84–87 |
| src/Models/Api | |||||
| CustomResourceApiRequest.cs | 100% | 100% | 100% | 100% | |
| ResourceEvent.cs | 100% | 100% | 100% | 100% | |
| src/Models/Commands | |||||
| StreamClassCommands.cs | 100% | 100% | 100% | 100% | |
| StreamDefinitionCommands.cs | 84.62% | 100% | 85.71% | 84% | 61–63, 89 |
| StreamingJobCommands.cs | 100% | 100% | 100% | 100% | |
| src/Models/Resources/Status/V1Alpha1 | |||||
| V1Alpha1StreamStatus.cs | 100% | 100% | 100% | 100% | |
| src/Models/Resources/StreamClass/V1Beta1 | |||||
| V1Beta1StreamClassSpec.cs | 85.71% | 100% | 85.71% | 85.71% | 12 |
| src/Models/Resources/StreamDefinitions/Base | |||||
| IStreamDefinition.cs | 90% | 83.33% | 100% | 100% | 29 |
| src/Services/Base | |||||
| ICommandHandler.cs | 100% | 100% | 100% | 100% | |
| src/Services/CommandHandlers | |||||
| AnnotationCommandHandler.cs | 73.24% | 66.67% | 100% | 72.13% | 37–40, 57–60, 69–72, 79–85 |
| StreamingJobCommandHandler.cs | 84.51% | 80% | 100% | 84.48% | 44, 54, 64–69, 88–90 |
| UpdateStatusCommandHandler.cs | 91.14% | 75% | 100% | 91.43% | 100–101, 42–45, 83 |
| src/Services/HostedServices | |||||
| HostedStreamingJobOperatorService.cs | 0% | 0% | 0% | 0% | 16–24, 27–29, 29, 29–36, 39–42 |
| src/Services/Metrics | |||||
| DeclaredMetrics.cs | 67.65% | 60% | 75% | 70% | 26–31, 33, 33, 33, 33 |
| MetricsReporter.cs | 85.29% | 100% | 75% | 85.71% | 50–53 |
| src/Services/Metrics/Actors | |||||
| MetricsPublisherActor.cs | 57.14% | 25% | 66.67% | 58.14% | 42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95 |
| src/Services/Operator | |||||
| StreamClassOperatorService.cs | 93.06% | 62.50% | 100% | 96.55% | 100, 102, 77, 77, 81 |
| StreamingJobOperatorService.cs | 90.60% | 83.33% | 100% | 92.59% | 113–117, 122, 126, 131, 72, 72, 76 |
| StreamOperatorService.cs | 80.37% | 68.97% | 90.91% | 84.14% | 100–102, 145–146, 146, 146, 148–149, 158, 168–173, 191, 193, 197, 197, 203, 205, 67–68, 68, 68–69, 82–83, 83, 83, 83, 83, 83, 83–86, 88, 98–99 |
| src/Services/Repositories/CustomResources | |||||
| StreamClassRepository.cs | 100% | 100% | 100% | 100% | |
| StreamDefinitionRepository.cs | 0% | 100% | 0% | 0% | 19–22, 27–34, 38–43 |
| StreamingJobTemplateRepository.cs | 0% | 0% | 0% | 0% | 21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–48 |
| src/Services/Repositories/StreamingJob | |||||
| StreamingJobRepository.cs | 58.82% | 100% | 66.67% | 57.14% | 33–38 |
Resolves https://github.com/SneaksAndData/arcane-operator/issues/47
Scope
This PR finalized code changes made in #47 and fixes the services injections in the Operator project. Also, fixed the default image tag in the Helm chart.
Implemented:
StreamingJobMaintenanceServiceConfiguration->StreamingJobOperatorServiceConfigurationUseDeveloperExceptionPageand the unused service injections.UpdateStatusCommandimplementationAdditional changes:
build_helm_chartaction to version v0.1.6build_helm_chartactionvletter from the default versoin templateChecklist
latestcommit.