search

Sneeds-Feed-and-Seed / sneedacity

Audio Editor
https://sneedacity.org
Other
886 stars 62 forks source link

Error when running pkgbuild on artix (ffmpeg5) #281

Closed longboarder241 closed 2 years ago

longboarder241 commented 2 years ago

After following the steps for doing a makepkg my install stalls at 74% with this message;

: warning: extra tokens at end of #undef directive make[2]: *** [src/CMakeFiles/Sneedacity.dir/build.make:173: src/CMakeFiles/Sneedacity.dir/SneedacityApp.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [CMakeFiles/Makefile2:3001: src/CMakeFiles/Sneedacity.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... Any help would be great
TWilldigg commented 2 years ago

Same issue here. Albiet without the warning: extra tokens. Progress 76% non pkgbuild on arch. image

TWilldigg commented 2 years ago

Found an issue in tenacity repo, ffmpeg 5 is the issue, follow the link: https://github.com/tenacityteam/tenacity/issues/705 to fix building.

Ckath commented 2 years ago

not really a fix to build it on 4.4, its going to have to just be beat into compiling. I'll try messing with the unmerged pr made to audacity

TWilldigg commented 2 years ago

Yeah, I have a segfault on the compiled binary any ways, although I have no idea where to start with that.

Ckath commented 2 years ago

the audacity source and the sneedacity one arent as compatible as they used to anymore with audacity having made the continuous awful effort to move random things into libraries/, was trying to just upgrade all the ffmpeg related parts and slap the pr ontop but its not working out quite as well as I hoped. the futile effort so far https://github.com/Ckath/sneedacity/tree/ffmpeg5 might look at it again when sober

TWilldigg commented 2 years ago

Not entirely sure how audacity is put together/designed, so I'm afraid I can't really help.

Ckath commented 2 years ago

the gist of it is the same as roughly all issues before it that involved upstream or wild fixes: the code 'compiles', however due unknown knowledge of how cmake works or how the project builds it fails at linking. the conan removal stuff stayed at this stage for ages but at that time there were more people with better ideas. an alternative would be to look into why the current ffmpeg related code cant deal with ffmpeg5 and slowly nudge it towards wanting to compile under ffmpeg5, what I've done currently is just take the audacity code with all the new ffmpeg interaction and try to hammer it into sneedacity which is many codebase redoals behind of it at this point. your messing around with the source until it compiles is going to be as good as mine.

I am not a c++ dev, I'm not very familiar with cmake, to this day I have no clear idea of what causes it to build and links the way it does

Ckath commented 2 years ago

insult to injury image

Ckath commented 2 years ago

got something to compile and link, please see how the pr works out. it at the very least builds and runs on an up to date arch system