search

SneezingCactus / manifold-server

Server application repository for Manifold, an open-source implementation of the bonk.io multiplayer servers.
MIT License
2 stars 5 forks source link

NoHostSwap, Types.d.ts finished #1

Closed WolfPRAcc7 closed 5 months ago

WolfPRAcc7 commented 5 months ago

Couple things you should review / test:


   if (this.config.endRoomNoHostSwap) {
          this.logChatMessage(`* ${leavingPlayerName} left the game and closed the room."`);
          process.exit(0);
        }

Whether process.exit(0) is a good enough way to the close room, (I am afraid bonk will instantly kick you out since the socket is closed rather then still seeing the closed the room message)

I added an avatar shape enum however see if you want me to move this to another file or change the type to an integer export enum eAvatarShape { // Idealy large enums like this should be moved to another file

Thirdly. noHostSwap should also be settable through the terminal? todo

WolfPRAcc7 commented 5 months ago

Thirdly. noHostSwap should also be settable through the terminal? todo

done

SneezingCactus commented 5 months ago

thank you!!!! I'll remove noHostSwap as setting autoAssignHost to false does basically the same thing. Room closing functionality will only be accessible through the server terminal, and instead of outright closing the server, it will keep the room open but it will also remove game host privileges to the current game host and block any attempts at joining after it's been closed.