Sneezry / authenticator

This repository has moved to https://github.com/Authenticator-Extension/Authenticator
Apache License 2.0
175 stars 92 forks source link

Simple bug fix: trim spaces off of secret key when adding #156

Open tnhutch opened 7 years ago

tnhutch commented 7 years ago

You've got a great extension. Just one minor suggestion: when a user is adding a new secret key in "Manual Entry" mode, you should trim off any spaces. Oftentimes users are copying and pasting their key and they may accidentally include a space at the end. When they do, your extension currently shows them this error:
"Secret Error. Only Base32 (A-Z, 2-7 and =) and HEX(0-9 and A-F) are supported. However, your secret is..."
Most users don't understand this error and you could solve the confusion by trimming spaces off of the beginning and ending of the secret key when they click "OK". Thanks!