search

Sneezry / authenticator

This repository has moved to https://github.com/Authenticator-Extension/Authenticator
Apache License 2.0
174 stars 95 forks source link

Add translate button #221

Closed mymindstorm closed 6 years ago

mymindstorm commented 6 years ago

Closes #220

ThePlenkov commented 6 years ago

looks like your commit crashed everything.. the app doesn't work anymore

mymindstorm commented 6 years ago

Crap, I literally made a fix PR minutes after he accepted the main one but it looks like I was too late. Sorry

ghost commented 6 years ago

i think error here file javascript/popup.js +document.getElementById('menuTranslate').innerHTML += browser.i18n.getMessage('translate');

mymindstorm commented 6 years ago

There is already a fix at #222 that just needs to be pushed.

ThePlenkov commented 6 years ago

image

ThePlenkov commented 6 years ago

there is no check on tabs length..

In my case tabs is empty.. so it means tab.url crashes.

I cannot blame the previous commit - as this popup.js fully belongs to the current one