Sneezry / authenticator

This repository has moved to https://github.com/Authenticator-Extension/Authenticator
Apache License 2.0
175 stars 92 forks source link

Authenticator BROKEN #223

Closed adsactly closed 6 years ago

adsactly commented 6 years ago

I shut my PC off last night and now when I try to use the Authenticator everything is showing up blank I can't even access the Settings or Add or Remove Codes and No Codes are Showing!

Please Help this is an Emergency.

adsactly commented 6 years ago

document.getElementById('menuTranslate').innerHTML += browser.i18n.getMessage('translate');

ThePlenkov commented 6 years ago

i confirm

ThePlenkov commented 6 years ago

Hopefully your code had a check for WebKit so in Firefox it works stable even now

mymindstorm commented 6 years ago

@ThePlenkov what I pushed was pretty much the same as this commit which is sort of the problem. Firefox uses browser.i18n and Chrome uses chrome.i18n and I forgot to change that. Though the Firefox version is unaffected and has a separate repo at mymindstorm/authenticator

adsactly commented 6 years ago

yeah well now nothing is showing we tried going back the Version 4.18 and there is Codes Imported. Its good thing we have a backup but its from a LONG time ago. We really hope you can fix this issue because this is very bad we have several QRCodes we can't access now :(

mymindstorm commented 6 years ago

@adsactly no data has been lost, it's just crashing and isn't showing the codes. After another update is pushed they will be back.

adsactly commented 6 years ago

OK We hope so because not even the older version is showing any codes.

adsactly commented 6 years ago

What exactly did you even update in the first place? Everything was working perfectly fine did you guys add a translation feature or something?

mymindstorm commented 6 years ago

A button in-between the feedback and source code buttons that would link to here to make it easier for people to contribute translations.

Saurabh995 commented 6 years ago

Hi, is there any way I can access the qr codes.. as I am unable to login to various sites.

mymindstorm commented 6 years ago

@Saurabh995 Not currently. Update with fix coming soon. All codes are safe.

wrath1 commented 6 years ago

Just made an account for this very reason im glad I found answers. btw, it's showing blank for everyone correct?

Saurabh995 commented 6 years ago

Isn't any cache locally maintained for all the added qr codes?

mymindstorm commented 6 years ago

@Saurabh995 this issue isn't with storage and it hasn't been touched.

zetb612 commented 6 years ago

How long does it take to fix the error?

Saurabh995 commented 6 years ago

@mymindstorm What I am saying is that ..aren't the secret keys stored locally in my chrome extension data??

mymindstorm commented 6 years ago

Probably, they are stored using chrome.storage.sync. The issue here is that the script that causes codes to load is crashing.

bmg177 commented 6 years ago

sigh, Im an idiot for not having a recent backup I guess although Ive never had an issue like this in many years. Locked out of some very important things I need to access right now. How does this happen? 24 hours MINIMUM for a fix?

john19991 commented 6 years ago

Had some important activities to do this morning, the deadline of which expires in the next 10 min. All this happens because of a stupid mistake by one of the contributors...Damn, I cant wait for 24 more hours Please fix this quick

bmg177 commented 6 years ago

Same here. Really bad timing. To say Im upset right now is an understatement

mymindstorm commented 6 years ago

No one should be relying on this as their only method to get two factor codes. If any of you have a backup you can load an older version of the extension and restore from your backup, and you should be able to use it.

bmg177 commented 6 years ago

Yes its my fault for not being prepared for this. I cannot locate my backup at this time. Took it for granted because Ive never had a problem for many years. Is there anything else I can do? What is this chrome.storage.sync you speak of? Pardon me, Im not familiar with this kind of stuff

bmg177 commented 6 years ago

"I don't really know how long it will take, probably somewhere between 12-24 hours plus the time it take for the extension to update"

Is there a file I can update or anything I can do on my end that will speed up this process?

john19991 commented 6 years ago

@mymindstorm Alright, fair enough. Where do I get the older version of the extension? I was unable to find it. I need it for chrome desktop

mymindstorm commented 6 years ago

Here is an archive I found: https://crx.dam.io/ext/bhghoamapcdpbohphigoooaddinpkbai.html

Use version 4.18

Go to chrome://extensions and drag the zip you download into the page after disabling the new version, the import a backup using the menu

ghost commented 6 years ago

also you can copy Extenstions/bhghoamapcdpbohphigoooaddinpkbai/4.19_0/* to arbitrary dir. then open javascript/popup.js 60 line and replace document.getElementById('menuTranslate').innerHTML += browser.i18n.getMessage('translate'); to document.getElementById('menuTranslate').innerHTML += chrome.i18n.getMessage('translate'); and install it temporarily. don't forget export your listings.

mymindstorm commented 6 years ago

It's under the javascript directory

adsactly commented 6 years ago

OK we did this but there are a few newer ones that are not showing up for some reason. Is it possible this update destroyed some of our keys?

mymindstorm commented 6 years ago

The update only changed one line of code related to localization, it didn't touch storage.

adsactly commented 6 years ago

OK well, that is very strange because the newest OTP Codes are not showing up at all. but mostly all the other ones are showing.

adsactly commented 6 years ago

OK so the issue is still not fully resolved and ALL Codes are still safe even the ones we saved this past week?

adsactly commented 6 years ago

Please let us know and We will get down from the Tower and We won't JUMP.

mymindstorm commented 6 years ago

They should be ok

bmg177 commented 6 years ago

editing the popup.js file and using that is telling me the extension is corrupted

I made a copy of the popup.js file and edited line 60 then swapped that file with the old one. Is there something else I have to do? Also, what does "dont forget to export your listings" mean

Thanks

Alternating commented 6 years ago

https://crx.dam.io/ext/bhghoamapcdpbohphigoooaddinpkbai.html <<-- none of these will install.. All of these say "windows cannot open this file" also indicateds in chrome "failed to install"

john19991 commented 6 years ago

Did anyone have success with the older version? Damn, this is crazy....Im losing patience now

bmg177 commented 6 years ago

I can get version 4.18 working but I cant successfully get the updated popup.js file to work

bmg177 commented 6 years ago

When this is fixed will it just automatically update the same way it automatically when to shit?

ThePlenkov commented 6 years ago

i changed the file but chrome loads cached version - cannot figure out what to do

manib-kumar commented 6 years ago

by when it'll get fixed?

hartatyfatshaf commented 6 years ago

OMG what should we doing now, please fix it soon.... 1 day 24 hour and more site can't access

QuestUA commented 6 years ago

jesus some brilliant hands did this shit...

devdevan commented 6 years ago

i did this "also you can copy Extenstions/bhghoamapcdpbohphigoooaddinpkbai/4.19_0/* to arbitrary dir. then open javascript/popup.js 60 line and replace document.getElementById('menuTranslate').innerHTML += browser.i18n.getMessage('translate'); to document.getElementById('menuTranslate').innerHTML += chrome.i18n.getMessage('translate'); and install it temporarily."

succesfully goes to setting. and now i think successfully lose my data because i cant export anything just wait for update if u dont know what to do...

ThePlenkov commented 6 years ago

for me it's even worse - I cannot remember password.. Tried all my possible passwords but have this:

image

ThePlenkov commented 6 years ago

there is no way to restore your password - so it's even more not secure than storing your tokens

john19991 commented 6 years ago

Im not a technical person, so I do not really understand any of those codes, plus I not not want to waste time downloading worthless zip files....Please get this fixed immediately

glukhovs commented 6 years ago

Only 1 question. If there is only one line has been changed in the new version that messed everything up. WHY 12-24 to get it fixed?

Sneezry commented 6 years ago

Authenticator for Chrome extension 4.19 has an issue to show codes, but your data is safe. The issue is caused by undefined namespace which is used in Firefox:

https://github.com/Sneezry/authenticator/blob/ed23dd24718c4712823a13ee419036591b524b4f/javascript/popup.js#L60

4.20 is released, and your extension should be upgraded in one hour.

reklaman commented 6 years ago

I upgraded to version 4.20 and I have all my codes disappeared .... this is what such a joke.

Sneezry commented 6 years ago

comment removed by misleading issue