SnekNOTSnake / my-personal-list

An app to organize and track your local anime collections.
GNU General Public License v3.0
76 stars 4 forks source link

MacOS #3

Open Hyper3557 opened 2 years ago

Hyper3557 commented 2 years ago

Pls release a macOS version of this. It is super amazing and I cant wait to try it. I have a 2TB storage of anime downloaded. Also pls make a detailed instruction on how to use this. It will be greatly appreciated.

SnekNOTSnake commented 2 years ago

Mac releases can only be build on Mac:

macOS Code Signing works only on macOS. Cannot be fixed.

We need help from someone who uses MacOS to build them. When I tried to do that (using Linux), it threw the following error:

 electron-builder  version=22.14.13 os=5.4.0-104-generic
  • loaded configuration  file=/media/Alpha/Projects/vite/my-personal-list/electron-builder.js
  • writing effective config  file=release/1.0.2/builder-effective-config.yaml
  ⨯ Cannot find module 'dmg-license'
Hyper3557 commented 2 years ago

I am 100% willing to help you. Can you perhaps send me your Discord tag so that we can get in contact? I have quite a lot of experience in coding. I think it would really help this project.

SnekNOTSnake commented 2 years ago

That's very good of you, sir Hyper3557! I don't use Discord, however. But fear not, building your own package is very simple (at least on Windows and Linux), you just need to run a couple of commands:

git clone https://github.com/SnekNOTSnake/my-personal-list.git
cd my-personal-list
yarn
yarn build
yarn package:mac

To be honest, I don't know what are those license and "Code Signing" thing that's exclusive only on mac. The above commands assumes the "code signing" thing is done automatically by Mac.

Hyper3557 commented 2 years ago

I tried what you said. Here is the code it shows in terminal. The application just closes randomly, I would like to know if there is a fix.

$ electron-builder --mac • electron-builder version=22.14.13 os=21.0.1 • loaded configuration file=/Users/arjundev/my-personal-list/my-personal-list/electron-builder.js • writing effective config file=release/1.0.2/builder-effective-config.yaml • packaging platform=darwin arch=arm64 electron=17.0.1 appOutDir=release/1.0.2/mac-arm64 • skipped macOS application code signing reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities= 1) B8B69A91DDA2A4B29D70E7843C03E1250D96973A "Email Hidden" 2) F683AF26585D23FC78107577828190896A0D371A "X-MacBook-Air.local" (CSSMERR_TP_CERT_EXPIRED) 2 identities found Valid identities only 1) B8B69A91DDA2A4B29D70E7843C03E1250D96973A "arjuoon@gmail.com" 1 valid identities found • building target=DMG arch=arm64 file=release/1.0.2/v1.0.2-my-personal-list.dmg • Detected arm64 process, HFS+ is unavailable. Creating dmg with APFS - supports Mac OSX 10.12+ • building block map blockMapFile=release/1.0.2/v1.0.2-my-personal-list.dmg.blockmap ✨ Done in 25.28s.

Hyper3557 commented 2 years ago

I dont think your application has been code signed. You will have to code sign It