search

SnijderC / dyplayer

Abstracton for DY-XXXX mp3 player modules over UART.
Other
110 stars 30 forks source link

DYPlayer::getDevice should have parameter #2

Closed SnijderC closed 4 years ago

SnijderC commented 4 years ago

I guess I interpreted the manual incorrectly, this was already not doing exactly what I expected but in hindsight that makes sense.

It should be refactored to check if a storage device is "online", probably return a boolean, in the spirit of DYPlayer::checkDeviceOnline(). The latter should probably be the name of the former.

SnijderC commented 4 years ago

No, I was wrong it is implemented okay, maybe the name should be changed, but it's not clear to me what this command does and what aa 0a does..