Fix for Linux - Githubissues

acaleechurn commented 4 years ago

Hello,

Would it be possible to port the audio jack fix to Linux? I have a corebooted T440p and the only thing which does not work properly is audio. When inserted the headphone is detected but there is no output. Docking audio also does not work but if i plug in a second headphone in the laptop jack while the other one is connected to the dock, I get docking audio. The Coreboot guys don't know how to fix this yet...

If i play with hdajackretask, i can enable the dock audio but the speakers are then permanently muted :(

Sniki commented 4 years ago

Can you give me more in details what actually is CoreBoot and why should we use it ?, what does it offer as additional?

acaleechurn commented 4 years ago

Coreboot replaces the stock bios with open source firmware which also enables you get rid of backdoors in the hardware such as Intel ME and effectively removes any whitelist or restrictions that may be present in the standard bios implementation.

acaleechurn commented 4 years ago

It seems that ALCPlugFix correctly reset the pins or verbs which allows the headphones to work properly. If you could explain what it does or cater for a linux build it would help a lot of users who have this issue.

https://doc.coreboot.org/mainboard/lenovo/t440p.html

You will note the following from the open bugs:

No audio output when using a headphone

Sniki commented 4 years ago

Can you link the source code (their github or so) so i can take a look at the code.

But keep in mind that i cannot promise a fix as it may be out of my knowledge scope.

acaleechurn commented 4 years ago

Thank so much, even for looking at the issue.

https://github.com/coreboot/coreboot/blob/master/src/mainboard/lenovo/t440p/hda_verb.c

Sniki commented 4 years ago

Thank so much, even for looking at the issue.

https://github.com/coreboot/coreboot/blob/master/src/mainboard/lenovo/t440p/hda_verb.c

Hmm, that doesn’t seem to complicated. The problem is that i have no hardware (T440P) to test this.

Will take a deeper look when i get some time for it and see what we can do.

It seems that it is missing some verbs/PinConfigurations

Sniki commented 4 years ago

Thank so much, even for looking at the issue. https://github.com/coreboot/coreboot/blob/master/src/mainboard/lenovo/t440p/hda_verb.c

Hmm, that doesn’t seem to complicated. The problem is that i have no hardware (T440P) to test this.

Will take a deeper look when i get some time for it and see what we can do.

It seems that it is missing some verbs/PinConfigurations

As i expected,

https://github.com/coreboot/coreboot/blob/master/src/mainboard/lenovo/x220/hda_verb.c

Compare the x220 file and it misses the misc stuff like jack detection etc.

I believe we can fix it

acaleechurn commented 4 years ago

Wow you're a star :) It's the first real lead I've seen in weeks.

acaleechurn commented 4 years ago

I just had a chat with one of the Coreboot developers and he would be grateful if you could share your fix or even just explain what to fix and he would write the patch.

mr.chromebox@gmail.com https://mrchromebox.tech/

Sniki commented 4 years ago

I just had a chat with one of the Coreboot developers and he would be grateful if you could share your fix or even just explain what to fix and he would write the patch.

mr.chromebox@gmail.com https://mrchromebox.tech/

Thanks for sharing this, i will let him know with the solution and send a pull request with the patch. I will let him know when i send it so maybe he can build one for testing so T440P testers can give it a try or if i can't provide the patch, i will tell him/them the fix.

Will check this on weekend or next weekend if no other priorities come up.

Will let you know there as well.

Sniki commented 4 years ago

@acaleechurn i think that your problem has been fixed.

I see that they added the missing verbs from hda-verb.c

acaleechurn commented 4 years ago

@Sniki where did you see this addition? I may have missed it as my problem is still the same.

Sniki commented 4 years ago

@Sniki where did you see this addition? I may have missed it as my problem is still the same.

https://github.com/coreboot/coreboot/blob/master/src/mainboard/lenovo/t440p/hda_verb.c

24 days ago i guess.

acaleechurn commented 4 years ago

Indeed, the correct verbs have now been added. Recompiled a new rom and everything now works. Thanks for the heads up 👍

Sniki commented 4 years ago

Indeed, the correct verbs have now been added. Recompiled a new rom and everything now works. Thanks for the heads up 👍

Great, enjoy

Closing since your problem has been resolved now.

Sniki / Lenovo-Thinkpad-T440P-Clover

Fix for Linux #7