search

Snipa22 / nodejs-pool

Other
479 stars 423 forks source link

Can i mine with wallet same as pool address ? #252

Open p2svn opened 6 years ago

p2svn commented 6 years ago

Can i mine with wallet same as pool address ?

shigutso commented 6 years ago

with the fee address yes I think so

with the pool wallet I don't think so, the payment would get an error (trying to pay to itself)

bobbieltd commented 6 years ago

Yeah, I like your answer. You can test by sending XMR from your wallet to your same wallet. If it pass then answer Yes, if not then answe No.

bobbieltd commented 6 years ago

Both pool and fee wallet, the answer is NO.

p2svn commented 6 years ago

the problem here is although i mine with different address "Invalid miner, disconnecting due to: Invalid payment │" How to now what miner with invalid address ?

Snipa22 commented 6 years ago

Looks like an invalid payment address, which means it didn't conform to the coin's spec: https://github.com/Snipa22/nodejs-pool/blob/master/lib/pool.js#L299

Technically, the pool will let you mine with whatever address you want, pool/fee/etc. I don't bother to verify the address against the pool's addresses, but it's a tad silly to do so, because of the transaction loop. The above code is what handles the verification of addresses during login.