[Question/request] XMR Fork support

[old-mikser]

Hello!

Will proxy support upcoming XMR (and other coins) cryptonight algoritm changes? Few miners added this support already. Can we wait for the same in xmr node proxy? Also what about nodejs pools?

[MaksimKlepikov]

It's just a proxy, not miner. i think algorithm changes not affected proxy, so modifing is not required

[bobbieltd]

Nothing to worry, Snipa will patch it.

[el00ruobuob]

If any patch is needed, i'm sure Snipa will provide an update soon. However, i wonder IF there is a need to update, or not. Proxy split workload to miners, but is not validating results. In my understanding, it means inputs are provided, but output is not check, and that last is where we expect the change in v7. So update needed for the inputs to be accurate or not?

[bobbieltd]

Yeah, you are right. Perhaps, the proxy doesn’t need any patch.

[MoneroOcean]

This proxy needs patch. It validates results.

[bobbieltd]

@MoneroOcean Thanks for info.

[grunjol]

If you don't use AESNI (like me and my old server) I was able to patch XNP, multi-hashing and cryptonote-util to be XMR V7 compatible, you can take a look at my fork https://github.com/grunjol/xmr-node-proxy

I hope Snipa will be back soon and make the necessary changes in the pool code and his multi-hashing AESNI fork.

[old-mikser]

@grunjol great job, so far! Didn't find where I can leave "issue request" in your fork, so just writing here - are you able to make XNP to work with non nodejs pools - regular cryptonote universal pools?

[grunjol]

AFAIK this proxy works with nodejs-pools.

[grunjol]

FYI, MoneroOcean fork is running Monero V7-ready on AESNI and non-AESNI machines tested with GCC 5, 6 and 7 (aka Ubuntu versions > 16.04).

[bobbieltd]

@MoneroOcean Thanks alot. People should install his repo for new xmr-node-proxy and packages.

[tinsami1]

I guess if we don't hear from @Snipa22 in the next few days, we'll have no choice but to use the fork by @MoneroOcean

[Ethorsen]

Look like Snipa did the work.

[netxecute]

@Ethorsen where do you see that?

[mpenagar]

So, there will be any update or should we move to MoneroOcean fork?

[old-mikser]

@grunjol Did you try it with non nodejs pool? Didn't work for me. Tried with a lot of pools. Also I saw issues where someone asked snipa to add compitability with cryptonote universal, but he asked for a tons of money. I don't think it worth it, as I saw it needs minor changes, I'm very sorry I'm bad at JS...

@mpenagar looks like we should

[mpenagar]

@Snipa22 has recently commited an "Update with new Cryptonight-Hashing library + the required changes for XMR". A newcomer question: What should I do to update it?

cd xmr-node-proxy && git pull && npm update

or just

cd xmr-node-proxy && npm update

Then, it's enough to restart it?

pm2 restart my-proxy

Or should I run the stop and full start command?

pm2 stop myproxy pm2 start proxy.js --name=myproxy --log-date-format="YYYY-MM-DD HH:mm Z" pm2 save

Thanks!

[MoneroOcean]

It is enough to do cd xmr-node-proxy && git pull && npm update and restart the proxy.

[mpenagar]

I got an error with git pull :

remote: Counting objects: 16, done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 16 (delta 11), reused 13 (delta 11), pack-reused 3
Unpacking objects: 100% (16/16), done.
From https://github.com/Snipa22/xmr-node-proxy
   d1092c6..238cf5e  master     -> origin/master
 * [new tag]         v0.0.1     -> v0.0.1
Updating d1092c6..238cf5e
error: Your local changes to the following files would be overwritten by merge:
        package.json
Please commit your changes or stash them before you merge.
Aborting

[MoneroOcean]

You have some local changes in package.json. Either remove them (git checkout package.json) or try to stash/repply them by doing git stash; git pull; git stash apply instead of git pull.

[mpenagar]

Thank! Yes, I did modify that file, I think due to a nonAES hardware problem.

Anyway, did you update it? I got a compilation error, I opened a new issue.

Thanks again!

[MoneroOcean]

I see. Likely you need to do git checkout package.json; npm update now because if you used some old multi-hashing for nonaes support there is a good chance it does not support cn-v7. https://github.com/MoneroOcean/node-cryptonight-hashing XNP uses now should work for both aes and non aes situations.