Snipa22 / xmr-node-proxy

221 stars 209 forks source link

Can we use it with other coins? ETN? #62

Open pinkflozd opened 6 years ago

pinkflozd commented 6 years ago

hello. i tried to connect the proxy to a ETN pool but im getting the following error:

proxy > 2017-11-24 13:41 +01:00: Master connected to pool: pool.electroneum.space proxy > 2017-11-24 13:41 +01:00: Received new block template from pool.electroneum.space proxy > 2017-11-24 13:41 +01:00: TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object. proxy > at fromObject (buffer.js:262:9) proxy > at Function.Buffer.from (buffer.js:101:10) proxy > at new Buffer (buffer.js:80:17) proxy > at new MasterBlockTemplate (/home/miner/xmr-node-proxy/lib/xmr.js:88:19) proxy > at handleNewBlockTemplate (/home/miner/xmr-node-proxy/proxy.js:717:32) proxy > at handlePoolMessage (/home/miner/xmr-node-proxy/proxy.js:694:17) proxy > at Socket.socket.on.e (/home/miner/xmr-node-proxy/proxy.js:657:17) proxy > at emitOne (events.js:96:13) proxy > at Socket.emit (events.js:188:7) proxy > at readableAddChunk (_stream_readable.js:176:18) PM2 > App [proxy] with id [1] and pid [11939], exited with code [1] via signal [SIGINT] PM2 > Starting execution sequence in -fork mode- for app name:proxy id:1 PM2 > App name:proxy id:1 online

can the proxy be made to work with ETN or other coins? i did try to make a /lib/etn.js and change the coin to etn in the config. i got the same error

jasminors commented 6 years ago

I am interested in this too and I am getting the same error for the us-etn-stats.hashparty.io pool.I've tried with another two ETN pools and the same results.monero pool seems fine with no issues

Snipa22 commented 6 years ago

Pool has to support it. Someone was working with me to have me extend the pool and proxy for ETN, but then someone on the ETN core team killed the project. So no, there's no support for ETN at this time, unless you find an ETN pool that's using NodeJS-Pool.

ddebin commented 6 years ago

There is at least https://electroneum.hashvault.pro/ which is using nodejs-pool for ETN.

jasminors commented 6 years ago

@Snipa22 Thanks for the update @ddebin Thanks for the link

pinkflozd commented 6 years ago

@Snipa22 Thanks for the info... So probably also other pools and other coins running cryptonote-universal-pool v1.1.6 won't work with your proxy?

mercenaruss commented 6 years ago

@pinkflozd @jasminors you tried to push Proxy to this pool(https://electroneum.hashvault.pro/)? Worked out?

pinkflozd commented 6 years ago

@mercenaruss yes it works... any pool running nodejs-pool works with the proxy

mercenaruss commented 6 years ago

@pinkflozd I have some issues with it,tried 2 pools with nodejs-pool and i have errors.

  1. pm2 stop proxy - To stop proxy
  2. Edit config.json , where i change just pool,port and wallet(to ETN) ,save file
  3. pm2 start proxy, proxy is up and working but with lots of errors

Error: 2017-12-08 00:56 +00:00: TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object. at fromObject (buffer.js:262:9) at Function.Buffer.from (buffer.js:101:10) at new Buffer (buffer.js:80:17) at new MasterBlockTemplate (/home/nodeproxy/xmr-node-proxy/lib/xmr.js:88:19) at handleNewBlockTemplate (/home/nodeproxy/xmr-node-proxy/proxy.js:717:32) at handlePoolMessage (/home/nodeproxy/xmr-node-proxy/proxy.js:694:17) at Socket.socket.on.e (/home/nodeproxy/xmr-node-proxy/proxy.js:657:17) at emitOne (events.js:96:13) at Socket.emit (events.js:188:7) at readableAddChunk (_stream_readable.js:176:18)

What this can be? NPN is crashing. https://github.com/npm/npm/issues/19350

and when I'm switching back to XMR pool,everything is working perfect,without any error.

Snipa22 commented 6 years ago

You pointed it at a non nodejs-pool based pool. The system isn't returning back the data expected, so it's freaking out and dying. Most ETN pools do not support the proxy.

mercenaruss commented 6 years ago

@Snipa22 this you explained up , but this pool(https://electroneum.hashvault.pro/) and another one (https://easyhash.io) is based on your xmr-node-pool and owner is confirming it,people reporting it like working. So I'm just confused.

Snipa22 commented 6 years ago

@mercenaruss https://easyhash.io/pools/electroneum doesn't appear to be based on NodeJS-pool. In fact, given the stats response, I can almost guarantee you it's built on Node-Cryptonote-Pool.

Edit: http://etn.easyhash.io:3631/ NodeJS-Pool returns: https://github.com/Snipa22/nodejs-pool/blob/master/lib/pool.js#L21

mercenaruss commented 6 years ago

@Snipa22 thank you very much. Now (https://electroneum.hashvault.pro/) is 100% is proven to be NodeJs-Pool.Had a discussion by 4 a.m. with admin of pool. He confirmed. But still the same error. Will try to submit more logs.

ddebin commented 6 years ago

It works for me with https://electroneum.hashvault.pro/.

Techjar commented 6 years ago

https://electroneum.hashvault.pro/ is also not working for me, it just spits out a whole bunch of ECONNREFUSED followed by Error response from pool pool.electroneum.hashvault.pro: {"code":-1,"message":"No active block template"} every once in a while.

mercenaruss commented 6 years ago

@Techjar yh,have the same issue,bu this is a pool problem,admins there have just issues all the time. Anyway a general integration of ETN to xmr-node-proxy is more welcomed ,so any pool can be used and not to rely on one(because only one at the moment is working with nodejs) hope to have a future support from @Snipa22

Snipa22 commented 6 years ago

XNP requires NodeJS-Pool updates for integration. If ETN miners are serious about wanting this, I'll make it easy. Raise 100k ETN, and I'll do the NodeJS-Pool and XNP integrations. If it looks like y'all are half-serious, I'll put up an address funds can be sent to.

If a single individual wishes to pay the entire bounty, they're welcome to, and will have the option of public, or private release of the ETN compatible pool source.

DaveLong commented 6 years ago

I have managed to get this working on an etn pool here: https://etn.luckypool.io

DaveLong commented 6 years ago

I copied xmr.js to a new file named etn.js and tweaked a few things (cannot remember exactly what now as I didn't run XNP for more than a few days - saw a significant drop in hash rate through XNP as oppossed to having miners connected directly to the pool.) I may well have not had an optimal configuration, but I didn't have time to experiment so decided to connect miners directly to the pool instead.