[Assignment 1] Review

[minhchau273]

Hi @Snorfermino,

It looks like you haven't pushed the latest code to your repo yet. Please update asap and let me know when you complete.

-Chau

[thanhtan1105]

:+1: Congratulation! You're the first one submitting this assignment. 🎉 The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Average
• Code Style: Good
• Visual Design: Average
• Usability: Good

Overall: Good

Detailed Notes

• Nice clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• When I scroll down to see more movie in list. Application is crash, because it cannot cast poster_path param in API. Check it again, bot girdView and tableView. Image below

• Using gridView: UICollectionView is correct but it is not good. Because girdView is name of component in Android. In iOS, we should define collectionView: UICollectionView to follow iOS style
• Nice for using UIScrollView to show content of Movie. Should remove red color in background, it not friendly for user
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• About UX, when I turn back from DetailViewController to MoviesViewController, I don't want to reload data, look like Instagram application. And UIRefreshControl just worked on GridView, I can not use it on ListView
• Losing data when loading movie information to cell

Using LineOfNumber in UILabel to limit content to show. If user want to read more detail, they can tap on cell.

• Nice for using AFNetworkReachabilityManager to check network and show friendly error message to user.
• I found duplicated code when you fetch data from API. We can mix 2 function in to one fetchMovieDataFromAPI and refreshControlAction.

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. 🏇