SnosMe / awakened-poe-trade

:heavy_dollar_sign: :hammer: Path of Exile trading app for price checking
https://snosme.github.io/awakened-poe-trade/download
MIT License
2.08k stars 451 forks source link

"Base Item" only appears on some items #1095

Open melink14 opened 1 year ago

melink14 commented 1 year ago

I use base item to check the rice of fractured and syth and other crafting bases but it seems like the tab doesn't always show up.

6L Armor where it shows up:

Details ``` Item Class: Body Armours Rarity: Rare Demon Salvation Triumphant Lamellar -------- Armour: 442 (augmented) Evasion Rating: 555 (augmented) -------- Requirements: Level: 69 Str: 95 Dex: 116 -------- Sockets: R-R-B-R-G-R -------- Item Level: 85 -------- { Prefix Modifier "Athlete's" (Tier: 5) — Life } +85(80-89) to maximum Life { Prefix Modifier "Pliant" (Tier: 7) — Defences, Armour, Evasion } +22(10-27) to Armour +27(10-27) to Evasion Rating { Suffix Modifier "of the Maelstrom" (Tier: 3) — Elemental, Lightning, Resistance } +37(36-41)% to Lightning Resistance { Suffix Modifier "of the Flatworm" (Tier: 9) — Life } Regenerate 15.5(8.1-16) Life per second ```

6L Armor where it doesn't show up:

Details ``` Item Class: Body Armours Rarity: Rare Corruption Pelt Triumphant Lamellar -------- Quality: +20% (augmented) Armour: 826 (augmented) Evasion Rating: 866 (augmented) -------- Requirements: Level: 69 Str: 95 Dex: 116 -------- Sockets: R-B-R-R-G-R -------- Item Level: 85 -------- { Prefix Modifier "Oyster's" (Tier: 4) — Life, Defences, Armour } +29(20-32) to Armour +19(18-23) to maximum Life { Prefix Modifier "Adaptable" (Tier: 2) — Defences, Armour, Evasion } +275(221-300) to Armour +240(221-300) to Evasion Rating { Suffix Modifier "of the Titan" (Tier: 2) — Attribute } +44(43-50) to Strength { Suffix Modifier "of the Phantom" (Tier: 2) — Attribute } +43(43-50) to Dexterity { Suffix Modifier "of the Maelstrom" (Tier: 3) — Elemental, Lightning, Resistance } +36(36-41)% to Lightning Resistance ```

Fracutred base where it does show up:

Details ``` Item Class: Body Armours Rarity: Rare Plague Hide Triumphant Lamellar -------- Armour: 437 Evasion Rating: 549 -------- Requirements: Level: 69 Str: 95 Dex: 116 -------- Sockets: R-G -------- Item Level: 85 -------- { Prefix Modifier "Robust" (Tier: 8) — Life } +53(50-59) to maximum Life { Suffix Modifier "of Abjuration" (Tier: 2) } +19(17-19)% chance to Suppress Spell Damage (fractured) (50% of Damage from Suppressed Hits and Ailments they inflict is prevented) (fractured) { Suffix Modifier "of the Panther" (Tier: 5) — Attribute } +32(28-32) to Dexterity { Suffix Modifier "of Haast" (Tier: 1) — Elemental, Cold, Resistance } +46(46-48)% to Cold Resistance -------- Fractured Item ```

Fractured Base where it doesn't show up:

Details ``` Item Class: Body Armours Rarity: Rare Miracle Pelt Triumphant Lamellar -------- Quality: +20% (augmented) Armour: 671 (augmented) Evasion Rating: 779 (augmented) -------- Requirements: Level: 69 Str: 95 Dex: 116 -------- Sockets: R-R -------- Item Level: 85 -------- { Prefix Modifier "Sturdy" (Tier: 4) — Defences, Armour, Evasion } +133(86-145) to Armour +114(86-145) to Evasion Rating { Prefix Modifier "Virile" (Tier: 6) — Life } +74(70-79) to maximum Life { Suffix Modifier "of Abjuration" (Tier: 2) } +17(17-19)% chance to Suppress Spell Damage (fractured) (50% of Damage from Suppressed Hits and Ailments they inflict is prevented) (fractured) { Suffix Modifier "of Bameth" (Tier: 1) — Chaos, Resistance } +33(31-35)% to Chaos Resistance -------- Fractured Item ```

I can't really figure out why it would only show up sometimes and I can't find anything in the settings either.

Version: Version 3.22.10003

SnosMe commented 1 year ago

Item quality +20% doesn't drop naturally, so I consider it a finished crafted item, and to not clutter UI hide this tab (because why would you sell a finished item for the price of base?).

https://github.com/SnosMe/awakened-poe-trade/blob/8035f8b7f339379b5b56dba2826035a598806402/renderer/src/web/price-check/filters/create-presets.ts#L62-L81

melink14 commented 1 year ago

I bought those bases on trade and I'm not sure why they were done like that. In general for myself, sometimes I check the price of a base of a finished item to see how much it costs to by a base for crafting a similar item. (it's also a quick way to get to trade for buying)

The space the extra tab takes up is neglible on my screen but I understand if you have a design preference around keeping your heuristics.

bucketcat commented 1 year ago

Items can drop with 20 quality, and higher after the loot pinata update (I have gotten 30 qual flasks drop naturally). Besides, applying quality to an item to increase the chance of 6s or 6l, to sell doesn't make it a finished item...

Currently, the only way to search for percentile on a 20 quality item is by scouring it. This can't be intended?

SnosMe commented 10 months ago

I see nothing critical here. Base Item tab is just a preset for your convience, you still can access all the filters when APT considers item to be finished

Tibbedoh commented 10 months ago

Could you please direct me to those filters? Also, were the default settings changed lately? This behavior is new, I used to have those tabs in every item before.

Just to make it clear, seems like almost every item I try (over 90% surely) does not show the tabs. It is not a minor issue.

SnosMe commented 10 months ago

@Tibbedoh see my comment above, no changes been made since Feb 2022

Tibbedoh commented 10 months ago

I have misinterpreted your previous comment. I thought one can edit those filters, I see they are hard-coded. Are those all the conditions? I still see some items in my stash that do not fulfil any of those. A rare weapon, no quality, no crafted mods, not mirrored or corrupted, yet I cannot see the base.

SnosMe commented 10 months ago

maybe its ilvl <82. I can answer for sure if you paste item

Tibbedoh commented 10 months ago

I have looked into the code beyond the portion in your comment, so now it's pretty clear. I think that I have just not noticed up until now that in some cases the tabs are hidden, but once I noticed, all of a sudden it's everywhere. Thanks for your patience :D

melink14 commented 10 months ago

I might be missing something as well. In the main view, I can see all the mods but it was only in the base tab that I could actually select fractured mods.

Is there a way to denote fractured mods in the main tab?

Tibbedoh commented 10 months ago

Yes, fractured mods can be seen under "hidden mods" section.

By the way, it would be really nice to be able to configure that "likelyFinishedItem" out. An example use case: I am crafting on an item with essences or fossils, I get a mediocre result, and I want to check whether I should sell it and buy a new base or keep going on the same base.