Don't apply search range to almost top rolled mods

SnosMe / awakened-poe-trade

:heavy_dollar_sign: :hammer: Path of Exile trading app for price checking

https://snosme.github.io/awakened-poe-trade/download

MIT License

2.08k stars 452 forks source link

Don't apply search range to almost top rolled mods #1128

Closed SnosMe closed 12 months ago

IvanHucko commented 1 year ago

@SnosMe Hi, I am looking for an issue to solve and this looks like interesting one to work on. Could you assign me? I would also welcome some information about the source code, maybe a hint where to look to find implementation of search range. Thanks

SnosMe commented 1 year ago

https://github.com/SnosMe/awakened-poe-trade/blob/b446c617cc1d4970067c209cf172a5dd93fcf72a/renderer/src/web/price-check/filters/create-stat-filters.ts#L163-L167

Basically if perfect roll then need to ignore percent argument, for filters created inside:

createExactStatFilters: all types of items
initUiModFilters: only for unique items

IvanHucko commented 1 year ago

Thanks for the info, I will take a deeper look at it. What would you suggest as an easiest method to get the modified source code compiled and running on my desktop?

SnosMe commented 1 year ago

yarn dev in /renderer and /main, also before that yarn make-index-files in renderer

IvanHucko commented 1 year ago

Hi, I am getting stuck on error trying to build the project. I am on Win11. I want to check if you have encountered something similar.

SnosMe commented 1 year ago

Run this command after installing dependencies 😅

IvanHucko commented 1 year ago

Hi, I think I managed to complete this issue. If stat on item is max rolled, percentage argument in filter will be replaced by 0. This is implemented in util.ts -> checkMaxedStatsPercent. I would suggest making an indicator that the stat is max rolled, simmilar to indicator that item has improved quality. I left a little comment in filterModifier.vue. Here is the pull request: SnosMe/awakened-poe-trade/pull/1143