Open kaffetorsken opened 7 months ago
I'm currently looking into how to fix it. It's actually not only shako but also other items where it can have different gem stats. Other example would be Replicas Dragonfang's Flight.
Here is an example of a shako and an explanation why it fails.
CTRL + C
Item Class: Helmets Rarity: Unique Forbidden Shako Great Crown -------- Armour: 151 Energy Shield: 31 -------- Requirements: Level: 68 Str: 59 Int: 59 -------- Sockets: B-R -------- Item Level: 85 -------- Socketed Gems are Supported by Level 1 Greater Multiple Projectiles Socketed Gems are Supported by Level 25 Divine Blessing +29 to all Attributes -------- The Azmeri must never touch the Tears of Maji, lest Viridi weep.
CTRL + ALT + C
Item Class: Helmets Rarity: Unique Forbidden Shako Great Crown -------- Armour: 151 Energy Shield: 31 -------- Requirements: Level: 68 Str: 59 Int: 59 -------- Sockets: B-R -------- Item Level: 85 -------- { Unique Modifier — Gem } Socketed Gems are Supported by Level 1(1-10) Greater Multiple Projectiles(Greater Multiple Projectiles-Controlled Blaze) { Unique Modifier — Gem } Socketed Gems are Supported by Level 25(25-35) Divine Blessing(Greater Multiple Projectiles-Controlled Blaze) { Unique Modifier — Attribute } +29(25-30) to all Attributes (Attributes are Strength, Dexterity, and Intelligence) -------- The Azmeri must never touch the Tears of Maji, lest Viridi weep.
As can be seen, the Gem stats show which possible rolls exist in the end of the line.
In this example this string: (Greater Multiple Projectiles-Controlled Blaze)
Not sure what the solution is though. The text is the normal item copy has the correct value, but is probably missing other details required for the search.
Text in (...)
also also not by default removable, as there is alot of situations where the text is actually needed.
One thing I just saw: It does work for Thread of Hope but should have the same problem. I'll check, how it's solved there and report back here.
Small update, found out how to fix it. There is advanced searches for different other items already (i.e. the Thread of Hope). These are currently missing for a few items. I'll send a PR with the added texts for replicat dragonfangs and shako. These are the two I know exist.
@SnosMe please close this guy's pull request 🥺
Replicas Dragonfang's Flight will be fixed. Shako unfortunately has a lot of conflicts that is hard for me to fix.
Forbidden shako rolls missing from pricecheck been like this for a few leagues, maybe someone knows how to fix this? :D