Please add a proper detach to the overlay window class as well

SnosMe / electron-overlay-window

Creating overlays is easy like never before

MIT License

201 stars 38 forks source link

Please add a proper detach to the overlay window class as well #3

Closed OSjoerdWie closed 4 years ago

OSjoerdWie commented 4 years ago

My target application doesn't seem to shutdown properly (Excel workbook on Windows 10). I suppose proper detaching could prevent this?

SnosMe commented 4 years ago

So how Excel shutdowns now?

OSjoerdWie commented 4 years ago

Apologies; I just realized that it seems like something that I changed at the same time as including your library - but forgot about - seems to have caused the issue. As it seems, the overlay had nothing to do with it.

somanuell commented 3 years ago

[...}

Hi SjoerD, could you have a look at https://github.com/durs/node-activex/issues/103 please.

Apology to Alexander for hijacking the issue, I don't know how to contact a dev here