search

SnosMe / electron-overlay-window

Creating overlays is easy like never before
MIT License
201 stars 38 forks source link

Fullscreen event not fired on macos #37

Open nickfujita opened 1 year ago

nickfujita commented 1 year ago

Trying out the demo with TextEdit on MacOS 13.5.1.

When toggling the app to fullscreen like is shown in the video on the original MacOS support PR the overlay disappears. I put a console log in the handleFullscreen event handler, but it appears that the event is never emitted. Also placed a console log in the handler, but only see resize events being fired, not fullscreen.

@hsource was wondering if you have seen this before, or possible are seeing the same on latest MacOS version? (don't have a way to test on older macos versions to confirm whether it used to work or not)

hsource commented 1 year ago

Yeah, the fullscreen detection was always a bit of a hack. I'm pretty sure there are better approaches, so you may want to rebuild and experiment with it if possible!

The function to really modify is here: https://github.com/SnosMe/electron-overlay-window/blob/master/src/lib/mac.mm#L570

I really based it off of a Stackoverflow answer which felt like a bit of a hack. I do wonder if there are newer APIs or approaches that are less of a hack.

nickfujita commented 1 year ago

Thanks for the response and the code reference. Will look into modifying this. 🙏🏼