Closed javierguzman closed 10 months ago
Did some force-push things, so closing it. I've checked and with your suggestion it should be fine now.
snosm@i5-2022:/mnt/c/Users/snosm/Documents/__dev$ objdump -T ./node.napi.node | grep GLIBC
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) free
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_create
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.3.4) __vfprintf_chk
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.3.3) __pthread_register_cancel
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_setschedparam
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) strlen
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.4) __stack_chk_fail
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_attr_init
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.3.3) __pthread_unregister_cancel
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_mutex_unlock
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) malloc
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.7) __isoc99_sscanf
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_self
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_attr_destroy
0000000000000000 w DF *UND* 0000000000000000 (GLIBC_2.3.3) __pthread_unwind_next
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) sched_get_priority_max
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) __sigsetjmp
0000000000000000 w DF *UND* 0000000000000000 (GLIBC_2.2.5) __cxa_finalize
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_mutex_lock
0000000000000000 DF *UND* 0000000000000000 (GLIBC_2.2.5) pthread_mutex_trylock
0000000000000000 DO *UND* 0000000000000000 (GLIBC_2.2.5) stderr
Hello all,
I am making this small change because it is always good practice not to use "latest" in CI/CD because it can break suddenly if the platform decides to update what latest mean e.g. latest today is ubuntu-22.04 and tomorrow is ubuntu-23.04, maybe the software deployed does not run properly in the new version.
In addition, I am having some issues under https://github.com/Dygmalab/Bazecor/issues/486 because uiohook-napi is built with ubuntu-latest which means is coming with latest glibc libraries but we need to support 20.04 and these users cannot update to the latest libraries.
Thank you in advance and regards