search

SnowdogApps / magento2-alpaca-components

Components library of Alpaca design system crafted for ecommerce
https://alpaca-components.now.sh/
MIT License
46 stars 10 forks source link

Removal of popup trigger component #465

Closed Igloczek closed 5 years ago

Igloczek commented 5 years ago

Origin of the problem was a broken popup component, caused by the wrong popupo id defined insidedata-popuptrigger of the trigger button.

Passing down the configuration of the button is not that easy, so instead of doing it, I just removed this ultra simple component and moved it to the popup component itself, because that was the only place where it was in use.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://magento2-alpaca-components-git-feature-popup-trigger.snowdog1.now.sh