search

SnowdogApps / magento2-alpaca-components

Components library of Alpaca design system crafted for ecommerce
https://alpaca-components.now.sh/
MIT License
46 stars 10 forks source link

Hide side-menu content from keyboard navigation #489

Closed redrohX closed 5 years ago

redrohX commented 5 years ago

When .side-menu__content is closed it's still accessible through keyboard navigation. So when tabbing through the header I would expect keyboard focus to move from the side-menu icon to the logo, instead it moves to the links in the .side-menu__content element which is positioned outside of the viewport, but not properly hidden. Confusing the user in the process and is an accessibility concern.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://magento2-alpaca-components-git-fork-redrohx-patch-1.snowdog1.now.sh

redrohX commented 5 years ago

@redrohX Thanks for this fix. Works better now :) Please update the changelog and I'll merge it. Thanks

Thanks for checking. I've updated the changelog and pulled in the latest dev changes. :+1: