search

SnowdogApps / magento2-alpaca-components

Components library of Alpaca design system crafted for ecommerce
https://alpaca-components.now.sh/
MIT License
46 stars 10 forks source link

fix rendering attributes for image and select elements #506

Closed Januszpl closed 4 years ago

Januszpl commented 4 years ago

It would be good to merge it asap ;)

Generally it allows to pass attributes to image/select elements. Now it's not possible in components as it won't be rendered properly.

For image it is useful for example to set width/height so we can set proper aspect ratio while waiting for lazysizes to load images and avoid content jump.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/snowdog/magento2-alpaca-components/jg7iwv5tj ✅ Preview: https://magento2-alpaca-components-git-fix-rendering-attributes.snowdog1.now.sh