search

SnowdogApps / magento2-menu

Provides powerful menu editor to replace category based menus in Magento 2
MIT License
295 stars 105 forks source link

Unused variables width and height #337

Open Morgy93 opened 1 month ago

Morgy93 commented 1 month ago

Hello,

there are some unused variables. Since I don't know the intention, I did not want to create a PR for removal only.

$imageWidth = $block->getImageWidth();
$imageHeight = $block->getImageHeight();

https://github.com/SnowdogApps/magento2-menu/blob/2.27.1/view/frontend/templates/hyva-menu-footer/menu/node_type/product.phtml

$imageWidth = $block->getImageWidth();
$imageHeight = $block->getImageHeight();

https://github.com/SnowdogApps/magento2-menu/blob/2.27.1/view/frontend/templates/hyva-topmenu-desktop/menu/node_type/product.phtml

Morgy93 commented 4 weeks ago

You might want to consider running stuff like https://github.com/slevomat/coding-standard/blob/master/doc/variables.md#slevomatcodingstandardvariablesunusedvariable

andrzejborkowski commented 4 weeks ago

hi @Morgy93, thanks for reporting this issue! I created an internal ticket SMM-12 and our dev will check it soon.