SnowdogApps / magento2-menu

Provides powerful menu editor to replace category based menus in Magento 2
MIT License
299 stars 105 forks source link

Registering custom Vue component does not work #351

Open rikwillems opened 7 hours ago

rikwillems commented 7 hours ago

When I register a custom Vue component in Snowdog\Menu\Model\VueProvider the backend will resolve it to the Snowdog_Menu path where it won't be found.

The origin of the issue can be found here: https://github.com/SnowdogApps/magento2-menu/blob/6c74665722eab734543bea29a00b006e9368b4a5/Model/VueProvider.php#L9 https://github.com/SnowdogApps/magento2-menu/blob/6c74665722eab734543bea29a00b006e9368b4a5/Model/VueProvider.php#L32

Each component is mapped to the Snowdog_Menu path where the custom component is not to be found. The documentation mentions you need to do it this way, which is not going to work.

I will do it through a plugin on the VueProvider which will work. As a solution either the documentation needs to change or the implementation of VueProvider.

andrzejborkowski commented 2 hours ago

Thank you for reporting the issue, I created an internal ticket SMM-32 for our dev team and we'll provide the feedback once we check it