search

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

Page is unresponsive after closing login popup in checkout #156

Closed TomFranssen closed 7 years ago

TomFranssen commented 7 years ago

In the checkout page when you close the login popup after opening you cannot click anywhere on the page. This is because the backdrop behind the modal doesn't get removed. The JavaScript for the modal at magento/module-ui/view/base/web/js/modal/modal.js looks at the CSS transition property to remove the backdrop. This value for the transition property is invalid that's why the transition property never get's picked up.

Leland commented 7 years ago

You're merging into master – this has already been fixed on develop by #152. @Igloczek maybe time to release? This is a pretty serious bug.

Januszpl commented 7 years ago

Yes. @Igloczek release or hotfix at least.

Igloczek commented 7 years ago

@TomFranssen As @Leland mentioned the issue with transitions was already fixed on develop branch, but there is one more change in your code in sidebar column variable.

Could you explain how it's related to the reported issue?

Leland commented 7 years ago

That's from #131

Igloczek commented 7 years ago

Ah, okay! BTW. Expect a release soon.