SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

Mobile Menu Account Links not copied over #182

Closed drdreamm closed 6 years ago

drdreamm commented 6 years ago

Hi Snowdog

There seems to be an issue with the inclusion of the theme.js file which copies over the account menu items to the mobile menu account tab. The Account tab is empty.

Igloczek commented 6 years ago

Indeed something is wrong, b/c we have more JS files than the LESS version of the Blank theme. I'll check it out.

drdreamm commented 6 years ago

I found a solution : I copied files (requirejs-config.js and the missing JS files ) from magento2ce/vendor/magento/theme-frontend-blank/Magento_Theme to the theme that I am using to extend blank /app/design/frontend/COMPANY/blank/Magento_Theme and it worked - so it's wasn;t including these

screen shot 2018-01-10 at 17 42 16

Igloczek commented 6 years ago

Please update to 1.0.4, I updated all JS according to the changes in Magento core.

drdreamm commented 6 years ago

cool thx