search

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

You may not @extend an outer selector from within @media #184

Closed mzeis closed 6 years ago

mzeis commented 6 years ago

Note: the error message is the same as in #165 but I decided to create a new issue since the circumstances are different. Please close this issue if you feel this is a duplicate.

When using this theme with Magento 2.2.3 and frontools 1.5.11, since today we get this error when executing gulp styles:

$ gulp styles --gulpfile vendor/snowdog/frontools/gulpfile.js
[16:13:08] Working directory changed to /path/to/magento/src/vendor/snowdog/frontools
[16:13:09] Using gulpfile /path/to/magento/src/vendor/snowdog/frontools/gulpfile.js
[16:13:09] Starting 'styles'...
[16:13:09] Starting 'inheritance'...
[16:13:12] Finished 'inheritance' after 2.86 s
Error in plugin 'sass'
Message:
    ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/styles/vendor/magento-ui/_utilities.scss
Error: You may not @extend an outer selector from within @media.
       You may only @extend selectors within the same directive.
       From "@extend .abs-add-clearfix-desktop" on line 254 of ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/Magento_Sales/styles/_module.scss
        on line 66 of ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/styles/vendor/magento-ui/_utilities.scss
>>     &:before,

   ----^

[16:13:13] gulp-notify: [Error running Gulp] Error: ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/styles/vendor/magento-ui/_utilities.scss
Error: You may not @extend an outer selector from within @media.
       You may only @extend selectors within the same directive.
       From "@extend .abs-add-clearfix-desktop" on line 254 of ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/Magento_Sales/styles/_module.scss
        on line 66 of ../../../var/view_preprocessed/frontools/frontend/Snowdog/blank/styles/vendor/magento-ui/_utilities.scss
>>     &:before,

   ----^

[16:13:13] gulp-notify: [Error running notifier] Could not send message: not found: notify-send
[16:13:13] Theme: blank print.css Compiled!
[16:13:13] Finished 'styles' after 3.85 s

I noticed that npm-install still installs gulp-sass@3.1.0, but this now installs node-sass@4.8.1 instead of node-sass@4.7.2 on Friday. (There are more version changes for other packages but this stuck out to me as a somebody not very experienced with frontend).

Igloczek commented 6 years ago

Check this one https://github.com/SnowdogApps/magento2-theme-blank-sass/issues/87

mzeis commented 6 years ago

Thanks, I'll close this one then and follow #87.