Incorect number divisions in sass

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme

MIT License

383 stars 150 forks source link

Incorect number divisions in sass #197

Closed lumnn closed 5 years ago

lumnn commented 6 years ago

Some Scss files contains a math calculations that are not calculated in compiled CSS file.

Compiled CSS:

Example line from repository: https://github.com/SnowdogApps/magento2-theme-blank-sass/blob/1.1.3/Magento_Catalog/styles/_widgets.scss#L74

Sass documentation on divisions: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#division-and-slash

Igloczek commented 6 years ago

Thanks for reporting, feel free to submit PR that will fix it. Would be also great to check the stylelint settings, because it should detect not valid CSS.

lumnn commented 6 years ago

Submitted PR #198

Igloczek commented 5 years ago

Relased as v1.2.0