search

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

Replace .abs-* classes with placeholders to reduce output css #214

Closed jevgenijmokrousov closed 5 years ago

jevgenijmokrousov commented 5 years ago

Utilise .abs- extenders in good maned and reduce amount of output css. In fact .abs- never used in Magento templates so placeholders would be better choose.

Before: .abs-button-responsive, .actions-toolbar > .primary .action, .actions-toolbar > .secondary .action {width: 100%; }

After: .actions-toolbar > .primary .action, .actions-toolbar > .secondary .action {width: 100%; }

Januszpl commented 5 years ago

Thanks for the PR however did you check https://github.com/SnowdogApps/magento2-theme-blank-sass#bug-reports-and-contribution-rules ?

Is this fixed in less blank theme? DId you post there first this PR?

jevgenijmokrousov commented 5 years ago

Thanks for response @Januszpl , this feature related to SASS version only, as far as I'm aware there is no placeholder feature available in Less, correct me if I'm wrong

Igloczek commented 5 years ago

As Janusz said, it's against our contributions rules, because this is just SASS port of LESS theme, we are not trying to fix any architectural decisions made in Magento core stylesheets. Since we are not using this theme in clients projects anymore, we need to keep maintenance as easy as possible, while any improvements like this make it harder, even if in general they are good.

Thanks for your time and engagement, if you are looking for a theme with higher code quality take a look at Alpaca theme