search

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

categorie and checkout pages have excessive layout width #223

Closed basbold closed 3 years ago

basbold commented 5 years ago

Issue description

Category and checkout pages have excessive layout width.

Examples

.page-layout-2columns-left .sidebar-main on the categorie page has a width of 300% and .opc-wrapper has a calculated width of 1500%.

Possible fix

I traced back a possible cause which was done in release 1.3.0.

reorganize imports of magento ui sass related files to match less theme structure (#204)

Extended vendor/magento-ui/_lib.scss and moved variables to the top of the import list.

//
//  Global lib
//  _____________________________________________

@import 'variables';
@import 'actions-toolbar';
...
masi commented 5 years ago

Had the same issue with .opc-wrapper (for Desktop).

Moving the import back to the top as basbold did fixed my problem as well.

richardWebdezign commented 5 years ago

Yeah, affected me too. variables needs to come before the other imports so that they can read the variables.

karlhass15 commented 5 years ago

Saw the issue when we pushed to staging, but not on my local. I just used a body class to override them rather than find needed specificity, because I wouldn't know till it hit staging.

PatrickWhitehouse commented 5 years ago

I also had this issue, spent hours trying to resolve it. Luckily stumbled across this and you're right, moving variables to the top fixes it.

stu177 commented 4 years ago

Any ETA for when this is pushed up in a release? Same question for #224.