SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme

MIT License

383 stars 150 forks source link

Reorganise styles/vendor/magento-ui/_lib Imports #223 #226

Closed pykettk closed 4 years ago

pykettk commented 5 years ago

Relates To

223

Description

Moved the variables import to be the first import statement to resolve excessive layout width reported by @basbold in #223

Krielkip commented 4 years ago

@Igloczek Can you look at this?

Januszpl commented 4 years ago

I've just made quick if there is similar issue on magento2 github related to magento blank and it seems they have similar issues https://github.com/magento/magento2/issues/8995

I will try to check it (after coming from holiday in 3 weeks). However it would be nice if someone could check it in magento2 blank and post PR there.

Igloczek commented 4 years ago

@pykettk please open the PR in the Magento core repository to move it too