search

SnowdogApps / magento2-theme-blank-sass

SASS based version of Magento 2 Blank theme
MIT License
383 stars 150 forks source link

@mixin lib-font-face missing font-display #232

Closed readio closed 2 years ago

readio commented 4 years ago

Pretty much as the title says. The 'lib-font-face' mixin in 'styles/vendor/magento-iu/_typography.scss' is missing 'font-display: swap'.

Not a major issue, but it gets flagged up on Google PageSpeed Insights

Igloczek commented 4 years ago

Is that a part of the Blank theme in Magento core? If not, please read readme.

Stevie-Ray commented 4 years ago

it is: https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.html

https://github.com/magento/magento2/blob/9544fb243d5848a497d4ea7b88e08609376ac39e/lib/web/css/source/lib/_typography.less

i've added it in #233 for now you can override the mixin to fix the issue.

Stevie-Ray commented 4 years ago

@Igloczek can you please update the scss to reflect the changes in Magento (2.3+) source code

Igloczek commented 4 years ago

@Stevie-Ray we are not using this theme in our company anymore, so there is no interest in doing such changes, but if you need them, please prepare a pull request, we will merge it and release it.

Igloczek commented 2 years ago

We are closing this project.