search

Snowflake-Labs / django-snowflake

MIT License
59 stars 15 forks source link

Add flake8 and isort linters #1

Closed timgraham closed 2 years ago

taylor-cedar commented 2 years ago

This makes sense. Should we add a pre-commit hook for formatting and add flake8/isort as a dev dependency? What is your opinion on using black formatter as well? We use that on our other repos.

timgraham commented 2 years ago

I could add pre-commit if you like, but I'm not in the habit of using it elsewhere. There was quite a bit of discussion when adding it to Django. I didn't like the fact that the version numbers had to be included in the configuration, which could mean a lot of commits to keep it updated.

Django doesn't have a dev requirements file. I don't think it adds much value.

I think Django will adopt black when it's no longer considered beta. I'm neutral about using it here right now.