Snowflake-Labs / django-snowflake

MIT License
59 stars 15 forks source link

Consider changing NAME to DB_NAME #65

Closed sfc-gh-hachouraria closed 1 year ago

sfc-gh-hachouraria commented 1 year ago

It isn't immediately obvious when filling the DATABASES config section on what the value of NAME should be. The example helps but the key name by itself (as NAME) is implicit in requesting a database name.

Could this config key name be changed from NAME to DB_NAME or DATABASE? This would align it with the other explicit key names.

timgraham commented 1 year ago

NAME is what Django uses. I don't think it's a good idea to name it differently in this backend.

sfc-gh-hachouraria commented 1 year ago

Thank you and apologies for the noise in that case, I should have compared against other existing configs.