search

Snowflake-Labs / django-snowflake

MIT License
61 stars 16 forks source link

Create a pull request template #70

Closed sfc-gh-ghernandez closed 1 year ago

sfc-gh-ghernandez commented 1 year ago

Creating a pull request template for future pull requests to django-snowflake. I just got it started, but @timgraham I think you could probably do a better job than I could adding items to the checklist. I pulled this from the pull request template used for snowflake-connector-python. Here's an example of a PR against that repo where you can view the template in action: https://github.com/snowflakedb/snowflake-connector-python/pull/1499

timgraham commented 1 year ago

Thanks for the proposal, but compared to the Python connector, this is a small project that, based on my experience with similar projects, should be easy to manage without this. I'm not a fan of the verbosity it adds to each PR description -- normally, I'd just delete it for my own PRs (which I expect to be the majority).

Regarding tests, there's no way to add tests without modifying Django's test suite, so if that's needed, I'll have to add tests to the Django fork used for testing until we can contribute the test upstream.

sfc-gh-ghernandez commented 1 year ago

Thanks for the proposal, but compared to the Python connector, this is a small project that, based on my experience with similar projects, should be easy to manage without this. I'm not a fan of the verbosity it adds to each PR description -- normally, I'd just delete it for my own PRs (which I expect to be the majority).

Regarding tests, there's no way to add tests without modifying Django's test suite, so if that's needed, I'll have to add tests to the Django fork used for testing until we can contribute the test upstream.

Sounds good!