search

Snowflake-Labs / schemachange

A Database Change Management tool for Snowflake
Apache License 2.0
482 stars 219 forks source link

R__ and V__ Script change list. Reopening after bugfix merge #150

Open CermitDFrog opened 1 year ago

CermitDFrog commented 1 year ago

My original PR for this closed when I merged the bugfix from PR 149 into my fork. This is just reopening after resolving any conflicts from bugfix to my branch.

Issue: 148 Original PR: PR 145

@sfc-gh-jhansen Versions and such are all up to date.

CermitDFrog commented 1 year ago

@eaguilera23 I updated the readme and the argeparse help value.

CermitDFrog commented 1 year ago

@sfc-gh-jhansen Were there other items that needed to be addressed for this?

sfc-gh-jhansen commented 1 year ago

Here there @CermitDFrog, sorry for the delay here. I've just been slammed with work lately and haven't had time to test/review this. Hoping to get to this in the next few days 🤞 .

afeld commented 1 year ago

Probably something that could wait to be a follow-up, but thoughts on the flag accepting a pattern and using a more common flag name like --path?

sfc-gh-tmathew commented 9 months ago

Hello @afeld, Thank you for bringing up the idea. Could you open a new issue and describe the --path option with an example and expected output.

sfc-gh-tmathew commented 9 months ago

Hello @CermitDFrog

We have started reviewing open issues and PRs. This PR still has merge conflicts. Could you help again by taking a look and see if you can resolve your fixes to the latest release ?

Thank you for your contributions!