search

Snowflake-Labs / schemachange

A Database Change Management tool for Snowflake
Apache License 2.0
502 stars 224 forks source link

SQL Syntax error when Snowflake role name includes special characters such as hyphens #215

Closed jonathancisneros closed 1 month ago

jonathancisneros commented 9 months ago

The USE ROLE and the other USE query template strings here: https://github.com/Snowflake-Labs/schemachange/blob/master/schemachange/cli.py#L213

are not using quoted values for the placeholder values, if there are special characters in the name of those values, the execution of the reset_session function fails with SQL compilation or syntax error.

please update the USE xxx template strings to support special characters by using quoted values like this: _q_set_sess_role = 'USE ROLE "{role}";'

dwelden commented 8 months ago

Duplicate of #186?

sfc-gh-tmathew commented 2 months ago

Thank you for highlighting this gap @dwelden @jonathancisneros

Just released 3.7.0 that addressed roles with special characters. Please test it out and let us know if this issue can be closed.

dwelden commented 1 month ago

This issue is resolved.

sfc-gh-tmathew commented 1 month ago

Thank you @dwelden for confirming. Closing this issue for now.