search

Snowflake-Labs / schemachange

A Database Change Management tool for Snowflake
Apache License 2.0
517 stars 228 forks source link

schemachange cli command returns Error: Empty SQL statement if .sql file ends with comments #240

Open ArnauMunsOrenga opened 8 months ago

ArnauMunsOrenga commented 8 months ago

Describe the bug

When creating a new .sql file to implement a change in our Snowflake database, the schemachange cli command returns an error: SQL compilation error: Empty SQL statement if the .sql file terminates with a comment.

The error does not appear if the file terminates with a valid SQL command.

To Reproduce Steps to reproduce the behavior:

  1. Create an .sql script with some SQL command to be implemented in snowflake database
  2. Make sure the file ends with some comments --some comment
  3. Run schemachange CLI command
  4. See error

Expected behavior I would expect schemachange not to return an "Empty SQL statement" error if the .sql file ends with some comments. I would expect it executes the SQL commands it finds in the .sql script, and implements changes on the database successfully.

Screenshots image

Schemachange (please complete the following information):

Additional context Add any other context about the problem here.

opodoprigora commented 7 months ago

We run into the same issue but it's unlikely to get fixed due to https://github.com/Snowflake-Labs/schemachange/issues/130#issuecomment-1289690445.

We postfix all commented out scripts with a dummy sql command like SELECT 1;