Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts
https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest
MIT License
535 stars 413 forks source link

feat: Add Dynamic Table Support for Stream Resource #2413

Open dcwangmit01 opened 8 months ago

dcwangmit01 commented 8 months ago

Terraform CLI and Provider Versions

$ terraform version
Terraform v1.7.1
on darwin_arm64
+ provider registry.terraform.io/snowflake-labs/snowflake v0.84.1

Use Cases or Problem Statement

Currently the Streams resource may be created on_table, on_view, and on_stage. However, there is no support for on_dynamic_table.

Effectively, the request is to enable the following in Terraform.

CREATE OR REPLACE STREAM deltaStream ON DYNAMIC TABLE dynamicTable

Relevant Issue: https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1922

Proposal

Enable this capability for creating streams on Dynamic Tables in the same way that on_table, on_view, and on_stage are supported.

How much impact is this issue causing?

Medium

Additional Information

No response

sfc-gh-asawicki commented 8 months ago

Hey @dcwangmit01. Thanks for creating the issue.

We have existing resources' rework on our roadmap: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#our-roadmap. I will bump this resource's priority slightly.

josdotso commented 7 months ago

Hey @dcwangmit01. Thanks for creating the issue.

We have existing resources' rework on our roadmap: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#our-roadmap. I will bump this resource's priority slightly.

Hi. Is this something that I could help push forward by contributing code? My team needs this functionality in order to justify our use of the provider. Not having it means two tools instead of one for us. Thanks!

sfc-gh-asawicki commented 7 months ago

Hey @josdotso. We are open to contributions!

However, we do not have yet clear contribution guidelines and PR requirements written down inside the repository. They are still to come in the upcoming weeks. If this is not a problem for you, we will be happy to review the change.

AZenat commented 3 months ago

Hey,

What is the update on that feature ?
I'm willing to take it if you're busy @josdotso.

sfc-gh-asawicki commented 3 months ago

Hey @AZenat. No update from our side yet. However, we have described the contribution guidelines: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/CONTRIBUTING.md#contributing, so it should be easier to make a contribution. :)

AZenat commented 3 months ago

Thanks @sfc-gh-asawicki, I will try to do it then.