Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts
https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest
MIT License
549 stars 420 forks source link

[Feature]: Add "CREATE NOTEBOOK" privilege to the list of allowed plural object types for all and future lists in snowflake_grant_privileges_to_database_role resource. #2960

Closed anita0918 closed 2 months ago

anita0918 commented 3 months ago

Use Cases or Problem Statement

All the schemas in the firm are managed schemas and are controlled by a terraform role. To create the Notebooks within underlying managed schema, user needs to apply CREATE NOTEBOOK on the schema which is not possible using current versions of terraform modules as notebook isn't included in the list of allowed plural object types.

Nested Schema for on_schema_object

The object type of the schema object on which privileges will be granted. Valid values are: AGGREGATION POLICY | ALERT | AUTHENTICATION POLICY | CORTEX SEARCH SERVICE | DATA METRIC FUNCTION | DYNAMIC TABLE | EVENT TABLE | EXTERNAL TABLE | FILE FORMAT | FUNCTION | GIT REPOSITORY | HYBRID TABLE | IMAGE REPOSITORY | ICEBERG TABLE | MASKING POLICY | MATERIALIZED VIEW | MODEL | NETWORK RULE | PACKAGES POLICY | PASSWORD POLICY | PIPE | PROCEDURE | PROJECTION POLICY | ROW ACCESS POLICY | SECRET | SERVICE | SESSION POLICY | SEQUENCE | STAGE | STREAM | TABLE | TAG | TASK | VIEW | STREAMLIT

Category

category:grants

Object type(s)

resource:database_role

Proposal

No response

How much impact is this issue causing?

Medium

Additional Information

No response

Would you like to implement a fix?

sfc-gh-jcieslak commented 3 months ago

Hey @anita0918 👋 I'll create a pr today and It'll be a part of the next release.

sfc-gh-jcieslak commented 3 months ago

Hey @anita0918 The privilege was added in the latest provider version (v0.94.0). Could you please upgrade and confirm it works on your end?

sfc-gh-jcieslak commented 2 months ago

Closing due to long inactivity.