feat: Row access policy resource v1 - Githubissues

Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest

MIT License

552 stars 420 forks source link

feat: Row access policy resource v1 #3063

Closed sfc-gh-jmichalak closed 2 months ago

sfc-gh-jmichalak commented 2 months ago

add show and desc output
rename fields
change signature to arguments
implement renaming
fix permadiff on body
adjust identifiers handling
adjust examples
gen resource asserts (config builders are not working because we have a required list argument)
improve handling data types
move parsing signature to sdk
support proper casing in arg names

Test Plan

[x] acceptance tests
[ ] …

References

https://docs.snowflake.com/en/sql-reference/sql/create-row-access-policy https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2053 https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1151

TODO (next PR)

rework data source

github-actions[bot] commented 2 months ago

Integration tests failure for f16580c47ef57d8fb91e33d0fe2ee8460780e42f

github-actions[bot] commented 2 months ago

Integration tests failure for 145a0d069e3e8cc7677c26a46a7ee5cac526838a

github-actions[bot] commented 2 months ago

Integration tests failure for f67fe87e6d07933bb96a3a9729aba425541707e1

github-actions[bot] commented 2 months ago

Integration tests failure for b9951a6afa1d861fe7d827af224c17411dd68b28

github-actions[bot] commented 2 months ago

Integration tests failure for 6cbc5b0849b2f8f4edd82771d3d5a478eea12446

github-actions[bot] commented 2 months ago

Integration tests failure for 6bfb6ed431c2e55f6e6241da32b679b7ae2930de

github-actions[bot] commented 2 months ago

Integration tests failure for 04df0b04525ef06d0c09b71ba6bebb1d4dafd976

github-actions[bot] commented 2 months ago

Integration tests failure for 497b25e0184f1696bfc597228fac6c2e6e330dcc