search

Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts
https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest
MIT License
552 stars 420 forks source link

[Docs]: Bad arg included in snowflake_shared_database example usage #3075

Closed deanmorin closed 2 months ago

deanmorin commented 2 months ago

Object type(s)

No response

Documentation Link

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/0.95.0/docs/resources/shared_database

Description

In the docs for snowflake_shared_database (v.0.93.0 onward), data_retention_time_in_days appears as an optional arg in the example usage, but doesn't appear in the schema section (and isn't actually supported by the resource).

Also, shared_database wasn't an option for "Object type(s)" when creating this issue. image

References

No response

Would you like to implement a fix?

sfc-gh-jmichalak commented 2 months ago

Hi @deanmorin 👋 Thanks for reporting this and creating the PR. We already reviewed it, and after resolving the comments, we can merge it 🙂

sfc-gh-jcieslak commented 2 months ago

The issue closed automatically (because of the fixes comment in your pr's description), but let me know If we should reopen it or it can stay as closed.