search

Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts
https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest
MIT License
552 stars 420 forks source link

feat: Add Resource for External Volumes #3106

Closed jdoldis closed 4 weeks ago

jdoldis commented 1 month ago

This PR adds the resource for External Volumes. This is part of a series of PRs aimed at adding provider support for Iceberg tables.

References

jdoldis commented 1 month ago

Hey @sfc-gh-asawicki / @sfc-gh-jcieslak / @sfc-gh-jmichalak 🙂

I’ll be on holidays for the next two weeks so won’t be able to respond to the review until I’m back. If you have the time you are welcome to take the PR over yourself to make changes / get it merged, otherwise I’ll take a look once I’m back. I’ve checked Allow edits by maintainers, so you should be able to push here if you like.

Cheers, James

sfc-gh-jmichalak commented 1 month ago

Examples are missing - please add them to examples/resources/external_volume (import.sh and resource.tf, check other resources like masking policy). After this, please run make pre-push which should regenerate docs.

sfc-gh-jmichalak commented 4 weeks ago

/ok-to-test sha=c4af02d4ee3a3b2213a95cd4946d3ad42dd747e9

github-actions[bot] commented 4 weeks ago

Integration tests failure for c4af02d4ee3a3b2213a95cd4946d3ad42dd747e9

jdoldis commented 4 weeks ago

Awesome, thanks @sfc-gh-jmichalak !