Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts
https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest
MIT License
552 stars 420 forks source link

chore: join object renaming tests into parameterized ones #3154

Closed sfc-gh-jcieslak closed 2 weeks ago

sfc-gh-jcieslak commented 4 weeks ago

Changes

Follow-up for https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3130#discussion_r1802982850.

Tests joined from standalone tests to parameterized ones. Two tests were left, because:

Commented test cases are there intentionally because normally they were skipped due to errors that cannot be asserted with terraform testing framework.

Question: The "important" tests are still not separated from the regular object renaming tests because they're currently failing in a way they're not assertable by the terraform provider testing framework (they will always fail). In this case, should we just leave it as is or just mark the "important" tests with TODO and ticket number?

github-actions[bot] commented 4 weeks ago

Integration tests failure for 76e4cbe356a03a8c657a9b34a2a4ea33018d2408

github-actions[bot] commented 4 weeks ago

Integration tests failure for 8373749026741924070a6068376d718555e55784